search

David-Maisonave / MediaFileDuplicateFinder

Media File Duplicate Finder finds duplicated video and image files based on similarities. Finds duplicates which have different file types, format, resolution, frame rate, watermark, and file tags.
GNU General Public License v3.0
24 stars 0 forks source link

[Help]: is FFmpeg5 a requirement for MFDF? #2

Closed Wrestor closed 1 year ago

Wrestor commented 1 year ago

Please enter a clear and concise detailed question.

Since 06fe8a6, VDF supports native ffmpeg v6 bindings. Please add it to MFDF as well. Also, please update the readme to reflect this, currently the readme doesn't outline any required FFmpeg version. Which for me returns Cannot find shared FFmpeg libraries.

What Operating System (OS)?

MacOS 13.4 (22F66)

What version of MediaFileDuplicateFinder?

1.2

Where did you download MediaFileDuplicateFinder from?

GitHub

Snapshot(s)

No response

David-Maisonave commented 1 year ago

Sorry for late reply. My email was down.

Also, please update the readme to reflect this, currently the readme doesn't outline any required FFmpeg version. Which for me returns Cannot find shared FFmpeg libraries.

I'll update the readme. I was able to duplicate this issue on Windows. As a temporary workaround, you can disable option [Use native Ffmpeg binding]

DisableUseNativeFfmpegBinding

I'll update you as soon as I have a fix.

Thank you for reporting this issue.

David-Maisonave commented 1 year ago

The native Ffmpeg option only seems to work with share GPL. See following link for downloads: https://github.com/BtbN/FFmpeg-Builds/releases/latest

However, I ran some test with this option enabled and disabled, and there was only a small difference in performance. Moreover the native option missed some duplicates which were caught by the Non-Native run. I ran this test with VDF to make sure the new code in MFDF was causing any issues. See following results:

The main reason for this option is because native mode is supposed to be much faster, but at least in Windows, this does not seem to be the case.

I couldn't find the FFMpeg share GPL MacOS version for download, and unfortunately I don't have a Mac machine which I can use to test this out on. If you can find the FFMpeg share GPL MacOS binaries, can you please download and test this out on your Mac machine.

Since 06fe8a6, VDF supports native ffmpeg v6 bindings.

If the test in other platforms show similar results to the test on Windows, I'm not sure if it's a good idea to continue binding support. There's only about a 10% difference, and that could be cause by the more accurate results being produced by the non-native mode. I need to find out why the native mode is failing to catch some of the duplicates before working on v6 binding.

David-Maisonave commented 1 year ago

Added Ffmpeg 6.0 support. For Windows MSI package, the 6.0 share GPL is now included.