David-OConnor / stm32-hal

This library provides access to STM32 peripherals in Rust.
MIT License
147 stars 44 forks source link

usbotg work, fixed build for f4 and l4x6 #58

Closed u296 closed 1 year ago

u296 commented 1 year ago

The usbotg_fs feature now works as intended

updated documentation, the l4x5 does not have otg support

updated feature gating for boards without the necessary peripherals

it currently compiles for all f4, l4x6 and h7 targets (except h7b3 which is broken elsewhere)

tested on stm32f411ceu6, no obvious problems

David-OConnor commented 1 year ago

Looks great! Will review sometime this week.

David-OConnor commented 1 year ago

Thanks! Solid addition and cleanup, including the validation of FS/HS etc.

Of note from your comments, it seems like there are PAC errors on l4x5 re OTG vs basic USB, which would have to be fixed upstream. And you're correct - this HAL currently doesn't support the "L4+" MCUs, eg with R in the name.