search

David-Woroniuk / Historic_Crypto

An open source Python library for scraping Historical Cryptocurrency data.
MIT License
90 stars 30 forks source link

Please support regex when searching ticker indices #9

Closed jmfrank63 closed 3 years ago

jmfrank63 commented 3 years ago

Nice work, thank you.

BTC-USD is a valid ticker, however, currently WBTC-USD, BTC-USDT and BTC-USDC are also found. By adding the regex=True parameter, you could now specify ^BTC-USD$ to just get BTC-USD.

I'll send a PR.

David-Woroniuk commented 3 years ago

This is the default for pandas.Series.str.contains, hence does not need to be explicitly defined. Please refer to the documentation on pd.Series.str.contains for further details.