search

David20122 / sound-space-plus

Rhythm-based aim game
https://wiki.rhythia.net/
MIT License
120 stars 17 forks source link

Fix discord SDK causing game to crash on Linux (Closes #18) #19

Closed mycpphurts closed 10 months ago

mycpphurts commented 11 months ago

Mentioning the original issue, libdiscord-game-sdk.so was indeed searching for libdiscord_game_sdk.so

Attached below is the latest commit (outside from this PR) indicating the dependency was named discord_game_sdk.so which libdiscord-game-sdk.so couldn't find nor load in the first place due to it looking for libdiscord_game_sdk.so

https://github.com/krmeet/sound-space-plus/blob/c930b2bc7cd2e5ecc02f0f243a4c1addfd3d467e/addons/discord_game_sdk/discord_sdk.gdnlib#L18

I'll also include the output of reading the libdiscord-game-sdk.so

$ readelf -a GitClone/sound-space-plus/addons/discord_game_sdk/libdiscord-game-sdk-godot.so | grep "discord_game_sdk.so"

 0x0000000000000001 (NEEDED)             Shared library: [libdiscord_game_sdk.so]

Also I suggest renaming the discord_game_sdk.so in the latest release for Linux to libdiscord_game_sdk.so as renaming it does fix the issue (Thanks to the community and @Neeko-iko for pointing it out)

mycpphurts commented 11 months ago

Day 1 of waiting for merge and/or review lmao

(Day 8 waiting)

mycpphurts commented 10 months ago

After a talk with the devs, won't be merged in favor of rewrite.

mycpphurts commented 10 months ago

DONT MERGE (its fixed anyway)