search

David20122 / sound-space-plus

Rhythm-based aim game
https://wiki.rhythia.net/
MIT License
120 stars 17 forks source link

Fix Note Visual Approach visible with Ghost enabled. #21

Closed mycpphurts closed 10 months ago

mycpphurts commented 10 months ago

References

NVA -> Note Visual Approach

Changes

Basil's calculations of NVA are weird, and it doesn't calculate the alpha, so, with Ghost enabled, NVA would be visible even if ghost was on. My (dumb) change fixes this... with 3 lines... I shit you not, read the commit log

Demos

NVA on Current Build:

https://github.com/krmeet/sound-space-plus/assets/57727007/d01b492a-06c8-4c08-a6f6-32b59bac6aed

NVA on a Built build with the code included in this commit:

https://github.com/krmeet/sound-space-plus/assets/57727007/fbbeccc9-b0e3-42d2-828c-cf02aa41aee1