fix replay song ids and note opacity

David20122 / sound-space-plus

Rhythm-based aim game

https://wiki.rhythia.net/

MIT License

129 stars 18 forks source link

fix replay song ids and note opacity #24

Closed NoiceBroice closed 6 months ago

NoiceBroice commented 6 months ago

this fixes problems caused by periods (".") in the song id when opening a replay example of issue: https://discord.com/channels/1064060807320702996/1228040695403642913

mycpphurts commented 6 months ago

Ngl I noticed this for some of my astra maps with dots. Valid PR. Will review and will get back at ya ❤️

NoiceBroice commented 6 months ago

I forgot pushing more changes would add to the pull request but this fixes another issue the note opacity option is currently just ignored now it is taken into account and correctly scales the fade in and fade out values

NoiceBroice commented 6 months ago

just the fade in and out had to be scaled the min was an initial fix to see the set opacity, but fade in and out has little to no effect if opacity was close or below the fade therefore just scaling those makes sense