DavidAnson / vscode-markdownlint

Markdown linting and style checking for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
MIT License
897 stars 166 forks source link

Not working auto-fix: MD036, MD028 on sample markdown with frontmatter #288

Closed justmars closed 9 months ago

justmars commented 1 year ago

Using v0.51.0, auto-fix on save works on some issues, e.g. extra spacing gets mutated into proper lines breaks. See vscode settings.json:

{
    "editor.codeActionsOnSave": {
        "source.fixAll": true,
        "source.fixAll.markdownlint": true
    },
    "markdownlint.config": {
        "MD025": false
        "MD026": false
      },
    "[markdown]": {
        "editor.formatOnSave": true,
        "editor.formatOnPaste": true
    }
}

See image one showing 9 errors on the tab:

Screenshot 2023-06-22 at 9 40 33 AM

See image 2 showing 4 errors on the tab after the extension kicks in on save:

Screenshot 2023-06-22 at 9 40 42 AM

The blue markers remain for MD036 and MD028. Is it correct that auto-fix should be able to remedy these issues?

Sample markdown with frontmatter ```md --- title: A Sample title members: - John - Sarah --- # Primary Heading Duplicate Lorem ipsum[^1] *My Premises* Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec scelerisque, mauris sed fermentum dignissim, nisi mauris accumsan dui, quis sodales est tellus nec sem. Maecenas vitae mauris ut nisl laoreet gravida sit amet in dolor. Sed elementum sem ut turpis imperdiet, et mattis eros imperdiet. Aenean eu convallis quam, vel rutrum nisl. Curabitur efficitur justo in odio bibendum imperdiet quis lacinia dolor. Pellentesque neque purus, elementum vel ante auctor, congue vehicula elit. Donec sodales hendrerit erat, vel bibendum massa lacinia vel: > XXXX > YYY > Curabitur eu volutpat orci. Maecenas dui urna, rhoncus ac felis quis, posuere semper urna. In suscipit tristique vehicula. Aliquam lacinia ullamcorper diam eget dapibus. Duis eros sem, condimentum eget molestie nec, fermentum nec orci. Cras eu tortor magna. Nam imperdiet lacinia vehicula. Quisque pharetra gravida tellus, non viverra libero interdum et. Curabitur risus libero, euismod eget vestibulum in, tristique vitae lacus. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc nec viverra eros. Ut a purus iaculis lectus aliquet tincidunt. Nam blandit placerat dictum. Etiam volutpat erat at ante efficitur, at viverra ipsum sollicitudin. Phasellus non ante ullamcorper, vehicula elit ut, commodo nibh. *This should be a heading* Maecenas enim metus, ultrices lacinia metus interdum, luctus cursus odio. Cras sollicitudin velit sit amet justo lacinia eleifend. Etiam risus elit, sodales at facilisis pulvinar, facilisis in nunc. Proin ut ex et lectus sollicitudin tincidunt non nec nisi. Nullam cursus mauris et metus consectetur volutpat. Aenean sed arcu rutrum, aliquam diam quis, rhoncus sapien. Donec a mauris eu leo euismod sodales. Proin pretium justo a euismod vehicula. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Ut porta quam lacus, nec tristique ipsum elementum et. Proin lacinia ultrices ligula, sit amet tempor enim aliquam quis. Maecenas et orci mi. Phasellus felis ipsum, gravida ac lobortis ut, facilisis eu ex. **FIN.** --- [^1]: Footnote sample --- ```
DavidAnson commented 1 year ago

The list of fixable issues is in the README: https://github.com/DavidAnson/vscode-markdownlint#rules

MD036 and MD028 are not listed there, so the behavior you observe is expected.

justmars commented 1 year ago

Thank you for the quick clarification. Appreciate it!