search

DavidArno / SuccincT

Discriminated unions, pattern matching and partial applications for C#
MIT License
266 stars 15 forks source link

TryGetValue for IDictionary<,> #19

Closed megafinz closed 7 years ago

megafinz commented 7 years ago

Currently that extension is defined for concrete Dictionary<,> type only. It would be nice if it works with all IDictionary<,> types.

DavidArno commented 7 years ago

OK, that should be easy. Wish you'd raised this a couple of days ago though as I could have added it to the v2.2.0 release that came out yesterday! 😀

megafinz commented 7 years ago

I wanted to do that myself and do a PR with a couple of other minor extensions that I use, but for some reason VS 2017 RC crashes when I try to open SuccincT.sln, VS 2015 complains about C# 7.0 language features and Rider is struggling with MSBuild scripts, so no luck with that.

DavidArno commented 7 years ago

v2.2.0 was created from the serialization branch, which is still compatible with VS2015. So if you pull that branch over to your repo and check it out, you should be able to make changes in VS2015 and submit a PR.

In what way does the master branch crash VS2017? Does it give any meaningful error?

If you have problems, let me know and I'll see if I can assist.

megafinz commented 7 years ago

serialization branch works well with both VS 2017 and 2015, but master just crashes IDE itself with no meaningful error. I tried starting VS with -Log switch, but I can't see any info about the crash in the log.

DavidArno commented 7 years ago

OK, thanks. I'll add a note that master might crash VS2017, whilst it's pre-release, to the README.

megafinz commented 7 years ago

Okay, I noticed that crash happens when SuccincT.Core project is being loaded. I removed it from the solution manually and now it opens just fine.

megafinz commented 7 years ago

Submitted PR.

DavidArno commented 7 years ago

v2.3.0 released.