search

DavidBM / rsmq-async-rs

RSMQ port to async rust. RSMQ is a simple redis queue system that works in any redis v2.6+
MIT License
43 stars 8 forks source link

fix several issues reported on issue #4 #5

Closed DavidBM closed 3 years ago

DavidBM commented 3 years ago

@rhuffus @voro2038 @aegis22 Would any of you take a look to the code changes?

GopherJ commented 3 years ago

LGTM, BTW I think we can have RsmqResult which will make things simpler

GopherJ commented 3 years ago

I just checked nodejs rsmq seems they are using {rsmqns}rt instead of {rsmqns}:rt, shall we follow their decision to keep the compatibility?

https://github.com/smrchy/rsmq/blob/f41b7e4eceaec51ea91933f30c54db44e94c07af/index.js#L373

DavidBM commented 3 years ago

Good call. That makes sense, but the issue that I see is that they document it like: {rsmq.ns}:rt:{qname} so I will ask them to choose to fix the documentation or the code.

DavidBM commented 3 years ago

I have added the RsmqResult type @GopherJ :)

DavidBM commented 3 years ago

Reported to js rsmq library on https://github.com/smrchy/rsmq/issues/128

DavidBM commented 3 years ago

@GopherJ They didn't respond yet to https://github.com/smrchy/rsmq/issues/128 so I will merge this one. Feel free to change the code in your local copy. Once they respond I will make any required change.