DavidBrainard / RenderToolbox3

Matlab toolbox for managing graphics rendering for psychophysics
MIT License
11 stars 4 forks source link

Renderer progress indicators #49

Closed benjamin-heasly closed 10 years ago

benjamin-heasly commented 10 years ago

Currently, PBRT and Mitsuba renderer plugins capture status and results from the unix() command. This is useful for logging during big, unattended jobs.

But capturing results also suppresses command outputs during rendering, which means Matlab won't display rendering progress indicators during rendering. Andy Lin noticed that if we don't capture the results, Matlab will display them live. See forum: https://groups.google.com/forum/?hl=en#!topic/rendertoolbox3-discussion/1ig1_91MEEk

So we have to choose between live progress indicators vs command result logging.

We can add a RenderToolbox3 preference value like "isCaptureCommandResults", and modify the PBRT and Mitsuba renderer plugins to capture results or display live results, as indicated.

I see two little catches:

We could write a utility that encapsulates these considerations;

This would invoke unix(), respecting the value of isCaptureCommandResults, and using a try-catch block as needed.

benjamin-heasly commented 10 years ago

5d726845159ec45c9530e036a856cff79ba9329b contains this change!