search

DavidBruant / usefulStackTrace

Firefox addon
http://davidbruant.github.io/usefulStackTrace/
MIT License
5 stars 1 forks source link

Console Usage? #1

Closed programmin1 closed 11 years ago

programmin1 commented 11 years ago

I can't find the usefulStackTrace.js mentioned in the readme. It seems the code has been rewritten for an extension, though it doesn't have an install.rdf? Where does the extension show the trace when working?

I didn't see a license in your code, would it be permissible to try and reuse this in my extension? https://github.com/programmin1/DevTools-Tweaks

DavidBruant commented 11 years ago

I can't find the usefulStackTrace.js mentioned in the readme.

Yes sorry, I've been moving things fairly violently recently. The original usefulStackTrace.js file to be used in a Scratchpad is in the history The add-on version (packaged a bit differently) is available under /lib.

I'll fix the Readme asap. Thanks for telling me :-)

It seems the code has been rewritten for an extension, though it doesn't have an install.rdf?

I use cfx (and the cfx xpi command) to build an xpi based on the package.json file (info). By the way, I use Webstorm which has a watcher feature that runs the command any time I edit a file, which is such a time saver!.

Where does the extension show the trace when working?

On the current tab WebConsole. I do some aliasing to get that working (and realize only now, that for that file, different console.log calls go to different consoles since my console variable isn't global...).

I did some very ugly hardcoding in the initial period just so the addon would be applied to only one test tab. This is because the Debugger API deoptimizes violently the JS and when applied to Twitter by mistake, I had to kill the browser because the script wouldn't stop and the "script is too long" dialog wouldn't pop up. Now that I have added the devtool pref, the next step is detecting whether the devtools are open and I'll remove that hardcoding soon.

I didn't see a license in your code

It's MIT licenced (it's written in the package.json file, but I should make it more clear and add a licence file)

would it be permissible to try and reuse this in my extension?

As long as you respect the MIT licence terms, no problem.

Thanks for your interest in my little script :-) Don't hesitate if you have other questions or suggestions of improvements!

DavidBruant commented 11 years ago

I feel my comments and this commit address all you concerns, so I'm closing. Feel free to open other issues.