search

DavidBruant / usefulStackTrace

Firefox addon
http://davidbruant.github.io/usefulStackTrace/
MIT License
5 stars 1 forks source link

Useful Stack Trace Not Working (Firefox 22) #2

Closed programmin1 closed 11 years ago

programmin1 commented 11 years ago

I just tried Useful Stack Trace, and it doesn't seem to give stack traces on any pages. I have checked the enabled option, and I don't see any console chrome errors relating to this addon in console2. Without digging into code much, I was wondering, could this be an incompatibility with upcoming Firefox 22?

DavidBruant commented 11 years ago

There was an hardcoding issue. I have addressed it Now, usefulStackTrace is enabled only when both the devtool option is enabled and the devtools are open in a tab. I have tested on Firefox 23 and 24 and it worked for me on the test file. I haven't checked with Firefox 22 yet. Can you retry? You can use the test file to check whether an stack trace is displayed in the console.

programmin1 commented 11 years ago

Just pulled the changes and installed to Firefox, it's not working on 22 on Ubuntu 13.04.

It would be great if this could work with the current version, but I may just wait for the 23 beta and try it again.

DavidBruant commented 11 years ago

Yeah, I just downloaded Firefox 22 to try and I see an error in the Error console (not the devtools one, the more privileged one). An import not returning an object with an expected property... I also noticed that there is no devtools Option panel in the Firefox 22 devtools (appeared in Firefox 23 which my addon relies on. This is more problematic as I want to provide the pref in the devtools. I won't support Firefox 22 for that reason.

The other reason is that I'm tired of writing hacks on top of hacks + browser compatibility code (in privileged code, wtf!), hacking XUL, working around different ways to import different sorts of modules (Jetpack/CU.import), to get a simple add-on working... Seriously, I've spent ~10 times more time writing code to integrate stack trace tracking in the browser than writing the stack tracking code. This is a bit ridiculous. I wish I could have dedicated this time to add support for long stack traces...

So yeah, sorry... no Firefox 22 support. As far as Firefox 23 and above, I'll commit to making sure it works. I'm on Aurora by default and will probably the first user of my own addon, so I should catch error early enough.