search

DavidBruchmann / typo3_forum

An Extbase-based TYPO3 Extension which is called typo3_forum. This fork is working in TYPO3 Version 8 and under development. Testing, Issue-reports and Pull-requests are welcome!
https://www.tukani.de
GNU General Public License v2.0
2 stars 2 forks source link

Use Doctrine DBAL #30

Open schams-net opened 6 years ago

schams-net commented 6 years ago

At least the following files contain some kind of $GLOBALS['TYPO3_DB'];, which could (should) be replaced with a proper Doctrine implementation.

Classes/Controller/TopicController.php Classes/Controller/ForumController.php

Classes/Scheduler/Counter.php
Classes/Scheduler/StatsSummary.php
Classes/Scheduler/Notification.php
Classes/Scheduler/DatabaseMigrator.php
Classes/Scheduler/SessionResetter.php
Classes/Scheduler/ForumRead.php
Classes/Scheduler/DatabaseMigrator.php
Classes/Service/Migration/AbstractMigrationService.php
Classes/Service/Migration/PrivateMessageMigrationService.php
Classes/Service/Migration/ForumMigrationService.php
Classes/Service/Migration/UserGroupMigrationService.php
Classes/Service/Migration/UserMigrationService.php
Classes/Service/Migration/PostsMigrationService.php
Classes/Service/Migration/TopicsMigrationService.php
schams-net commented 6 years ago

To clarify this issue. EXT:typo3_forum should use TYPO3/Extbase's DB layer (which uses Doctrine), rather than the deprecated $GLOBALS['TYPO3_DB'] construct.

DavidBruchmann commented 6 years ago

removed completely from the stroked classes (see above in issue description)