search

DavidBruchmann / typo3_forum

An Extbase-based TYPO3 Extension which is called typo3_forum. This fork is working in TYPO3 Version 8 and under development. Testing, Issue-reports and Pull-requests are welcome!
https://www.tukani.de
GNU General Public License v2.0
2 stars 2 forks source link

Solves #27 #53

Open mgrundkoetter opened 5 years ago

schams-net commented 5 years ago

I understand this is not your code, I am just wondering, maybe someone can explain if the ViewHelper really does what it is meant to do :-)

Description in the comment reads:

ViewHelper that renders its contents if there is a user currently logged in.

I'd say, either the function or the description is wrong. If the description is wrong, and the ViewHelper in fact should just check, if the current user is logged-in, can't we use Fluid's existing IfAuthenticated-ViewHelper (which derives from AbstractConditionViewHelper already)?

DavidBruchmann commented 5 years ago

sorry, I was mistaking in deleted comment, at least related to the changed code.

mgrundkoetter commented 5 years ago

Yeah, sure. But that is not backward compatible :-) Better: deprecate it now, remove it in the next major release.