search

DavidCain / mitoc-trips

The MIT Outing Club's trip management system
https://mitoc-trips.mit.edu
GNU General Public License v3.0
43 stars 9 forks source link

use an older version of django-localflavor #13

Closed chaoranxie closed 6 years ago

chaoranxie commented 6 years ago

use an older version of django-localflavor that contains localflavor.us.models.PhoneNumberField

DavidCain commented 6 years ago

Hey, Chao! As it were, the project doesn't actually use localflavor, or PhoneNumberField. I should probably remove that dependency altogether. The only reason that it's currently in the repository is that I haven't yet squashed all the migrations, and a current migration refers to the package. I'll be squashing commitn over in the branch that's migrating over to Python3 and Django 1.11.

What problem are you trying to solve? Just trying to get the repository up and running locally?

DavidCain commented 6 years ago

If you're trying to get your own setup created from scratch, I'll confess that I've neglected to keep that easy and up-to-date. You'll likely encounter some road bumps along the way, but it should still be possible to create your own local environment from scratch.

Again, the branch I have where we update to Python 3 & Django 1.11 should actually allow easy initialization from scratch.

chaoranxie commented 6 years ago

Hi David, yes, I was trying to get the repository running locally. I did succeed after making this changes. Not sure the status of the python3_django1.11 branch, is it all upgraded to python 3 and Django 1.11? either way, I am all set for now, Thanks so much for open sourcing the tool.

DavidCain commented 6 years ago

That's great to hear that you got things up and running!

The python3_django1.11 branch is currently running successfully on Python 3 and Django 1.10. It has no known errors, but I wish to dramatically expand test coverage on that branch before making the switch in production (I'd also like to bring Django up to 1.11, or even 2.0).

If you're experimenting with the project, I'd recommend checking out that branch instead (there's no documentation yet, but it should be straightforward).