DavidCain / mitoc-trips

The MIT Outing Club's trip management system
https://mitoc-trips.mit.edu
GNU General Public License v3.0
43 stars 9 forks source link

Render trip feedback newlines on profiles and the admin trips page. #21

Closed mglidden closed 5 years ago

mglidden commented 5 years ago

I wanted to use newlines in my feedback to separate out trip conditions from participant feedback. I believe I found all places where feedback shows up – on a profile, the admin page for a trip, and in leader applications – but let me know if I missed anything.

mglidden commented 5 years ago

Hey David – thanks for the detailed response! I appreciate how much time just making the reply takes

To give some more context – I was using newlines in my leader response to help separate relevant pieces of information. Nick made a great point at the leader retreat that conditions really change the experience of a hike, but are often left out of the feedback. I was putting in conditions as the first paragraph, then a newline to separate out the individual feedback (to make it easier to skim).

Good point on the multiple pieces of feedback in the admin view – I hadn't thought about that

How about this proposal:

  1. In the admin view, put a separator line between pieces of feedback, similar to what we have on the profile page
  2. In the admin view, we want to end condense newlines and strip leading & trailing whitespace. We could do this client-side easily enough (with pre-line and a regex), or use the linebreaks + escape filters server-side. The second way seems cleaner, but I'm open to your suggestions there
  3. In the profile view, strip trailing & leading whitespace so the views look the same
DavidCain commented 5 years ago

Client-side regular expressions for dealing with whitespace sounds like a nightmare. =P Returning escaped HTML is a JSON endpoint doesn't seem like the cleanest solution to me either.

But before we go to too far designing a solution, I want to make sure we're solving the right problem!

It sounds like what you're looking for is the ability to describe a trip's conditions in such a way that participant feedback can be presented in the context of a trip's conditions, no?

In that case, it sounds like what would be ideal is a new feedback mechanism where leaders can describe a trip's conditions once and have that be displayed alongside feedback in the relevant places. From my perspective, if your feedback is multiple paragraphs, then it's likely containing information that belongs elsewhere. =)

If I instead implemented the means of describing a trip's conditions, and made that a standard part of the feedback flow, would you consider that helpful? I see a few key benefits:

People have already requested such a mechanism, and I have a potential design which would help in solving some other outstanding requests as well. One example - people have floated the idea of a repository of leader's thoughts on their trips - notably what it was like to take particular trails in particular conditions. This information could be useful to future leaders considering trip itineraries.

If you're okay with it, I'm happy to just take the approach of adding a new trip feedback mechanism - it sounds like it may solve some problems for you!

mglidden commented 5 years ago

Yup, adding a specific way of recording trip conditions / reports would be really helpful in more ways that this! Happy to abandon this in favor of that approach