search

DavidCain / mitoc-trips

The MIT Outing Club's trip management system
https://mitoc-trips.mit.edu
GNU General Public License v3.0
43 stars 9 forks source link

Please update ws_gear.html #25

Closed ntitchener closed 4 years ago

ntitchener commented 4 years ago

Rev A of WS 2020 group gear updates to include Ice Climbing specific safety gear

codecov-io commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         152      152           
  Lines        8577     8577           
  Branches      643      643           
=======================================
  Hits         7547     7547           
  Misses        967      967           
  Partials       63       63
Flag Coverage Δ
#Python 87.9% <ø> (ø) :arrow_up:
#TypeScript 92.26% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b83b64...395f69c. Read the comment docs.

ntitchener commented 4 years ago

Neils-MacBook-Air:~ nat25$ git clone git@github.commailto:git@github.com:ntitchener/mitoc-trips.git Cloning into 'mitoc-trips'... Warning: Permanently added the RSA host key for IP address '140.82.114.3' to the list of known hosts. git@github.commailto:git@github.com: Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. Neils-MacBook-Air:~ nat25$

On Jan 6, 2020, at 10:50 PM, David Cain notifications@github.com<mailto:notifications@github.com> wrote:

@DavidCain approved this pull request.

Looks great! If you're so inclined, you can rebase your commits into one. An easy way to change them:

git clone git@github.commailto:git@github.com:ntitchener/mitoc-trips.git cd mitoc-trips git checkout patch-1 git reset HEAD~ git add ws/templates/help/leaders/ws_gear.html git commit --amend git push --force-with-lease origin patch-1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/DavidCain/mitoc-trips/pull/25?email_source=notifications&email_token=AHYDGBGXUKT4ITARRJGMSHTQ4P3XNA5CNFSM4KDN44G2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQ2QHZQ#pullrequestreview-339018726, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHYDGBE7RBKR2BNVLGYFRTDQ4P3XNANCNFSM4KDN44GQ.

DavidCain commented 4 years ago

It's fine - I'll just merge as-is.