search

DavidCain / mitoc-trips

The MIT Outing Club's trip management system
https://mitoc-trips.mit.edu
GNU General Public License v3.0
43 stars 9 forks source link

/profile/membership page #60

Closed ColeDCrawford closed 1 year ago

ColeDCrawford commented 2 years ago

We link to https://mitoc-trips.mit.edu/profile/membership/ from the "Join MITOC" page here: https://mitoc.mit.edu/join. If you're logged in, the /profile/membership page looks like it's trying to get your membership status, but just keeps hanging with the "Querying MITOC servers for membership status..." message. It does look like it can get my status at this endpoint: https://mitoc-trips.mit.edu/users/2726/membership.json. But the page itself just hangs.

Low priority but thought I'd flag it.

DavidCain commented 2 years ago

Thanks! This is a known issue, it only happens some of the time (refreshing the page should generally fix it).

The membership status widget is a new Vue.js component, isn't able to do animations for CSP reasons, and totally lacks a timeout aspect to it...

I've been meaning to dedicate more time to migrating over other parts of the application, and better leveraging Vue.js, but I just haven't gotten around to it, sorry.

ColeDCrawford commented 2 years ago

That all makes sense, thanks!

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: David Cain @.> Sent: Thursday, April 14, 2022 6:45:04 PM To: DavidCain/mitoc-trips @.> Cc: Crawford, Cole D @.>; Author @.> Subject: Re: [DavidCain/mitoc-trips] /profile/membership page (Issue #60)

Thanks! This is a known issue, it only happens some of the time (refreshing the page should generally fix it).

The membership status widget is a new Vue.js component, isn't able to do animations for CSP reasons, and totally lacks a timeout aspect to it...

I've been meaning to dedicate more time to migrating over other parts of the application, and better leveraging Vue.js, but I just haven't gotten around to it, sorry.

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DavidCain_mitoc-2Dtrips_issues_60-23issuecomment-2D1099694774&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=Cx6htUBu9_qa9NfkhF5VYT7-R5jFrP77d_-cdGRipz4&m=aMpuipXVq-xE5L4vsvxBtGESZhF5NLjIYcvrt_X-pr_iSHZrQelHxYLdzmbgS4_T&s=l8YCFq35TNZC3fNi9T4mcEH1i84Cm4nxxCzzeThkIPI&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD45X2RZN6FI2KOF3JYJBSLVFCNXBANCNFSM5TO7T76Q&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=Cx6htUBu9_qa9NfkhF5VYT7-R5jFrP77d_-cdGRipz4&m=aMpuipXVq-xE5L4vsvxBtGESZhF5NLjIYcvrt_X-pr_iSHZrQelHxYLdzmbgS4_T&s=AGLCoG_mpymZVeDc47u8tEBN9QOm9pBrqVSJYeSgNW8&e=. You are receiving this because you authored the thread.Message ID: @.***>

DavidCain commented 1 year ago

Thanks again for reporting this, Cole. I never did really fix the JavaScript widget, but half the fun of MITOC Trips is that I try to use as little JS as possible, and I fixed this issue by just eliminating use of the JS widget altogether.

We'll now be much faster in telling participants their membership status, and hopefully present the information more helpfully.

A longer explanation of what exactly I changed and why: https://github.com/DavidCain/mitoc-trips/issues/61#issuecomment-1378354923