search

DavidCramer / pods-frontier

Creates advanced view templates for displaying Pod data on the front end via a Shortcode.
42 stars 6 forks source link

Reverse cancel & submit buttons primary class usage #28

Open Shelob9 opened 10 years ago

Shelob9 commented 10 years ago

Same reason as I gave for #22. Lot's of buttons with the primary class that do cancel or delete and buttons for submit or add that do not have primary class. It's playing against the established usage pattern in WordPress admin.

DavidCramer commented 10 years ago

Agreed. I'm used to highlighting buttons that do dangerous actions like delete. But in WordPress it's opposite.

I'll make changes.

Shelob9 commented 10 years ago

You may be right about highlighting dangers, but going against an established pattern is a bigger danger. BTW I realize now that this same issue was bothering me in Caldera Forms, I kept removing things inadvertently and not realizing where they went.

DavidCramer commented 10 years ago

Ye I realized that and am working on it.

-----Original Message----- From: "Josh Pollock" notifications@github.com Sent: ‎2014-‎06-‎21 09:33 PM To: "pods-framework/pods-frontier" pods-frontier@noreply.github.com Cc: "David Cramer" dlcramer@gmail.com Subject: Re: [pods-frontier] Reverse cancel & submit buttons primary classusage (#28)

You may be right about highlighting dangers, but going against an established pattern is a bigger danger. BTW I realize now that this same issue was bothering me in Caldera Forms, I kept removing things inadvertently and not realizing where they went. — Reply to this email directly or view it on GitHub.