search

DavidFW1960 / bom-weather-card

Custom Animated Weather Card for any weather provider
Apache License 2.0
162 stars 37 forks source link

Add error checks #92

Closed Makin-Things closed 2 years ago

Makin-Things commented 2 years ago

This PR adds checks to stop .state of non-existent sensors being called and causing exceptions that blank the card.

DavidFW1960 commented 2 years ago

What is the conflict here preventing merging? Seems to be line 54??

<<<<<<< add-error-checks
          ${biggerIcon}
=======
          <span class="icon bigger" id="icon-bigger" style="background: none, url(${this._hass.hassUrl("/local/icons/weather_icons/" + (this.config.static_icons ? "static" : "animated") + "/" + this.weatherIcons[this.currentConditions] + ".svg")}) no-repeat; background-size: contain;">${this.currentConditions}</span>
>>>>>>> master

the ====== part?

DavidFW1960 commented 2 years ago

Also with our discussion on versioning we should make it 1.1.0 right?

Makin-Things commented 2 years ago

I think that would be a fair call for this one.

DavidFW1960 commented 2 years ago

Simon it was duplicating the span class at line 5x Not sure why... Can you check the js file 'looks right'? I also bumped the version as we mentioned above. I won't do the release until you confirm it looks ok.