search

DavidFeldhoff / al-codeactions

MIT License
17 stars 8 forks source link

Extract to label - should include ", comment= #113

Closed DavidRoys closed 2 years ago

DavidRoys commented 3 years ago

I don't know how to make a feature request, but I love the "Extract to label" feature you have. I would like it to also put in the comment part of the label description to adhere to AL(AA0470) variables with placeholders should have a placeholder explaining their content.

I would like to build this feature myself and make a pull request, but I don't have a clue how to start. Is there a step by step guide that would tell me how to set up a copy of this repo so I can make changes and test them in VS-Code? It's the testing of my changes that I am really not sure about. I think I can probably figure out the programming side from the source code.

DavidFeldhoff commented 3 years ago

Nice idea. I'm just thinking of developing the feature togehter with you and we're recording our session. We could start from setting up the environment on your local machine, creating a fork in your github, doing the changes on your machine, testing these, pushing these into your fork and creating a pull request to my repository. What do you think? If you feel uncomfortable with that, I can of course as well simply create a contribution.md-file or something like that.

Best regards David

DavidRoys commented 3 years ago

This is an amazing Idea and I think would help a lot of people like me that want to contribute but don’t really know how to start. It’s also a very generous offer of your time. I’m very keen to go ahead with this. I’ll send you my work email via Twitter DM so we can try to set something up.

DavidFeldhoff commented 2 years ago

fixed in version 1.0.8 by @DavidRoys in #125 :) Thanks to you!