search

DavidFeldhoff / al-codeactions

MIT License
17 stars 8 forks source link

[Bug] Create Overload procedure does not work in combination with named return values #120

Closed fvet closed 2 years ago

fvet commented 3 years ago

When creating an overload procedure for a function that has a named return value, the content of current procedure needs to be replaced by a call to the new procedure + assignment of the return value.

returnvalue

Actual (wrong) CreateAlert(pcodAlertID, pvarSourceRecord, ptxtMessage, AdditionalRemarks, pintPageID, false);

Expected AlertCreated := CreateAlert(pcodAlertID, pvarSourceRecord, ptxtMessage, AdditionalRemarks, pintPageID, false);

DavidFeldhoff commented 3 years ago

I'll fix that right away. Thanks :)

DavidFeldhoff commented 3 years ago

Short update: It's fixed locally for me, but I haven't published it yet as I also started working on #118 and #119 and I'm already pretty far, so I hope to get them published together this week.

DavidFeldhoff commented 3 years ago

Unfortunately, #118 and #119 takes a little bit more time to implement which is why I've published a version with #120 and #121 only for now (v1.0.4). But I'm still working on it, I just wanted to take out the pressure.