[Suggestion] 'Generate SetLoadFields' ?

[fvet]

Related topic: https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=1033577983172608

I recently started using the AL Toolbox extension to fix locations where SetLoadFields could be applied. I'm mainly worried on our core / large tables that are valid candidates for table extensions (and thus resulting in many - redundant - table joins) and gradually wanted to apply SetLoadFields per each table, by searching Get / Find operations on these tables and evaluate if the context would support a SetLoadFields.

I'm not convinced yet on the impact and if we should need to pro-actively add SetLoadFields on every record find/get statement for simple read operations. (https://demiliani.com/2020/10/12/dynamics-365-business-central-new-features-for-performant-code/#comment-26605), so I'd focus on the most important tables first.

It's however very time-consuming to review / evaluate all code and start applying the SetLoadFields, pushing me towards a more scripted approach / (batch / fix me) code action. (not knowing if MS would provide improved platform support ...)

Idea would be to scan:

• either the current editor/file or all files (filtered via a glob pattern)

Search SetLoadFields candidates for:

• a pre-defined set of 'core', critical tables (mainly ISV tables) or all tables (less-preferred)

Scan the code and apply SetLoadFields in simple / very specific cases only (can be gradually extended):

• Does not apply to global variables
• Does not apply to function parameters
• Only applies to local variables
• Does not apply for insert / modify / delete / rename
• Only applies for get / findfirst / findset / ...
• Does not apply for transferfields
• Does not apply for copies to temporary records
• Does not apply when the local var is passed to a function
• Does not apply when the local var is exposed via IntegrationEvent
• ...

Does this sound:

• A valid thing to do as part of the code review / best practice for new code?
• A command that fits the 'AL Code Actions' extension?

[fvet]

Closed. We got rid of the idea of pro-actively applying SetLoadFields...

[DavidFeldhoff]

Oh okay. I just waited for the answer of al-toolbox as they already have this functionality in some kind, so I thought anyway that I wouldn't have to implement it. But good to hear it's solved for you