search

DavidFeldhoff / al-codeactions

MIT License
17 stars 8 forks source link

Loop all hover messages #137

Closed jwikman closed 2 years ago

jwikman commented 2 years ago

Fix #136.

This change loops all hover messages when trying to parse the data types of parameters.

What do you think?

jwikman commented 2 years ago

Hmmm, the DevOps pipelines didn't seem to like this PR. But I'm not sure that this really has to do with my code change?

jwikman commented 2 years ago

The reasons for the pipeline failure could be that those OS versions has been deprecated in DevOps pipelines. See https://docs.microsoft.com/en-us/azure/devops/release-notes/2021/sprint-196-update and https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/

DavidFeldhoff commented 2 years ago

Hi Johannes, sorry for leaving you alone with the errors :D yes, that's right, the pipeline isn't working, but as I did not receive any PRs until now, I didn't care that much and have not looked into it yet. Sorry that I've confused you with that!

I won't be able to check the PR today, so I'll look into it tomorrow. But after reading your comments, it sounds very good. Thanks for your work and help :)

jwikman commented 2 years ago

It's no panic David, take your time. I've got an easy workaround for now. :)

DavidFeldhoff commented 2 years ago

I just updated the images, so that they're using always the latest ones and merged it into your branch to restart the checks. Looks better now ^^ The change as such is looking good. I think I wouldn't have thought that the hover messages are the issue there, so thanks again for helping! I'll merge it and publish it togehter with a few other smaller changes the next days.

Best regards David

jwikman commented 2 years ago

Thanks @DavidFeldhoff 👍