DavidRoys
commented
2 years ago Hi @jwikman. I'm in no position to give a definitive answer on this, but having looked at this problem for a while I can tell you the line of thinking that got us where we are. What you are suggesting is exactly what I wanted to do, but as you know the placement of arguments is different for Confirm compared to Error or Message (as the first argument for Confirm is a boolean for default). This means in order to do this properly we would need to identify the command that the string is within. This is possible (as there are other parts of David's add-on that do this) but parsing the code to find this is more work (for the extension not just the developer). One thing I didn't realise before David showed me something about how this all works is the solution for the code action is fully realised just in case you decide to invoke it. This would mean whenever you move the cursor to within a string that could potentially be a label and if the label has placeholders we would need to parse the object to determine the command within which the text is used and then also pull the additional arguments. This seemed like a lot of work, but again, totally worthwhile if it's doing something valuable. I then thought about the purpose of the comments. I think these are meant to be used for translators to help determine the context of the message. In that instance just subbing in the placeholder arguments doesn't really help. It might get you past the Codecop warning, but if we're not going to provide useful information, maybe we should just switch the warning off? David took the code that I wrote (which was pretty basic really) and made it really useful by including the snippet functionality (where your cursor is placed at the argument position and you can tab to the next) and I really like what David did with that. I guess what I'm saying in this comment is that I think it's a great idea but don't personally want to try to realise it. :-) Maybe David will have a crack at it though or maybe you fancy having a go?
jwikman
DavidFeldhoff
In #113 you and @DavidRoys added a Comment with %1, %2 etc when extracting a label - very useful!
But I would like to get the parameters added as default values for those placeholders.
Samples:
Message('Hello %1, %2', "No.", Name);Would then get the labelnewLabel: Label 'Hello %1, %2', Comment='%1="No."; %2=Name';And
Message('%1: %2', FieldCaption(Code), Code);Would benewLabel: Label '%1: %2', Comment='%1=FieldCaption(Code); %2=Code';etc.
There are sure some border cases where it gets hard(er) to identify the parameters, but we can always just fallback to blank.
What do you think?