DavidFeldhoff / al-codeactions

MIT License
17 stars 8 forks source link

Fix get record type parsing for unix #160

Closed tyurm closed 1 year ago

tyurm commented 1 year ago

Hello,

First of all, thanks for your extension - it helps a lot. I use your extension on Mac and faced an issue - CreateProcedure parse the "Record" type wrong:

image

"DEMO field" is just a custom field added to customer TableExtension

I have debugged your extension, and found that the problem is here: let hoverMessageLines: string[] = hoverMessage.split('\r\n');

I googled the problem, and found this solution - it fixed the problem on Mac: image

https://stackoverflow.com/questions/21895233/how-to-split-string-with-newline-n-in-node

Could you please check it on Windows, and add it to the master? Thank you in advance.

DavidFeldhoff commented 1 year ago

Hey, sorry for not getting back to you. I somehow missed this one and was quite busy. I understood your issue and thanks for your PR. I used your approach, but as I had multiple places of it in my extension, I fixed it everywhere (or at least am trying to do that :) ) It'll be part of the next release Best regards, David