search

DavidGolodetsky / GeekScore

A PWA for board games fans. It allows you to store your games, create teams, and collect statistics. It's built with MEVN stack, using Vue.js 2 and Vuetify.
https://geekscore.herokuapp.com
MIT License
8 stars 33 forks source link

removed win rate for a user when no win rates are recorded #193

Closed kits4 closed 3 years ago

kits4 commented 3 years ago

Closes #187

kits4 commented 3 years ago

also in app.vue there was an import error for setupFb it should be fbStart right should i correct that.

DavidGolodetsky commented 3 years ago

not sure if we need to change setupFb, cause currently, it seems to work fine. do you have any troubles with that? If you want you can create a separate issue for that

DavidGolodetsky commented 3 years ago

ah, now I see the problem with setupFb. strange, maybe firebase api was updated. I'll create a ticket later

kits4 commented 3 years ago

ya i was talking about the same.

kits4 commented 3 years ago

Hey @DavidGolodetsky, don't remove the winRates && part from v-if as it is use for null checking. Due to removal following error is coming in console.

image

DavidGolodetsky commented 3 years ago

oops, putting it back:)