Frotz 2.45pre does not compile for Apple MacOS Sierra 10.12 plus MacPorts

[codan-telcikt]

Frotz 2.45pre does not compile for Apple MacOS Sierra 10.12 plus MacPorts

System Info

$ uname -a
Darwin tim-mbp13 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

Build Log

$ cat src/common/defines.h
#define VERSION "2.45pre"

$ make clean

$ make
Creating src/common/git_hash.h
head: -: No such file or directory
Generating src/common/defines.h
Generating src/curses/defines.h
gcc -Wall -Wextra -std=gnu99 -g -o src/common/buffer.o -c src/common/buffer.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/err.o -c src/common/err.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/fastmem.o -c src/common/fastmem.c
src/common/fastmem.c:722:6: warning: variable 'gfp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (os_read_file_name (new_name, f_setup.save_name, FILE_RESTORE) == 0)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/common/fastmem.c:770:9: note: uninitialized use occurs here
    if (gfp == NULL && f_setup.restore_mode)
        ^~~
src/common/fastmem.c:722:2: note: remove the 'if' if its condition is always false
        if (os_read_file_name (new_name, f_setup.save_name, FILE_RESTORE) == 0)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/common/fastmem.c:695:6: warning: variable 'gfp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (os_read_file_name (new_name, default_name, FILE_LOAD_AUX) == 0)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/common/fastmem.c:770:9: note: uninitialized use occurs here
    if (gfp == NULL && f_setup.restore_mode)
        ^~~
src/common/fastmem.c:695:2: note: remove the 'if' if its condition is always false
        if (os_read_file_name (new_name, default_name, FILE_LOAD_AUX) == 0)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/common/fastmem.c:685:14: note: initialize the variable 'gfp' to silence this warning
    FILE *gfp;
             ^
              = NULL
2 warnings generated.
gcc -Wall -Wextra -std=gnu99 -g -o src/common/files.o -c src/common/files.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/hotkey.o -c src/common/hotkey.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/input.o -c src/common/input.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/main.o -c src/common/main.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/math.o -c src/common/math.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/object.o -c src/common/object.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/process.o -c src/common/process.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/quetzal.o -c src/common/quetzal.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/random.o -c src/common/random.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/redirect.o -c src/common/redirect.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/screen.o -c src/common/screen.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/sound.o -c src/common/sound.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/stream.o -c src/common/stream.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/table.o -c src/common/table.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/text.o -c src/common/text.c
gcc -Wall -Wextra -std=gnu99 -g -o src/common/variable.o -c src/common/variable.c

Archiving common code...
/usr/bin/ar rc src/frotz_common.a src/common/buffer.o src/common/err.o src/common/fastmem.o src/common/files.o src/common/hotkey.o src/common/input.o src/common/main.o src/common/math.o src/common/object.o src/common/process.o src/common/quetzal.o src/common/random.o src/common/redirect.o src/common/screen.o src/common/sound.o src/common/stream.o src/common/table.o src/common/text.o src/common/variable.o
/usr/bin/ranlib src/frotz_common.a

gcc -Wall -Wextra -std=gnu99 -g -o src/curses/ux_init.o -c src/curses/ux_init.c
In file included from src/curses/ux_init.c:46:
src/curses/ux_blorb.h:24:5: error: unknown type name 'ulong'; did you mean 'long'?
    ulong type;
    ^~~~~
    long
src/curses/ux_init.c:996:11: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign]
    dummy = dummy;
    ~~~~~ ^ ~~~~~
1 warning and 1 error generated.
make: *** [src/curses/ux_init.o] Error 1

[timtelcik]

Issue 43 is a duplicate of issue 44

https://github.com/DavidGriffith/frotz/issues/44

Please close this issue.