search

DavidGriffith / frotz

Infocom-style interactive fiction player for Unix and DOS (moved to https://gitlab.com/DavidGriffith/frotz)
GNU General Public License v2.0
209 stars 64 forks source link

src/common/quetzal.c: make fallthrough explicit #63

Closed escondida closed 6 years ago

escondida commented 6 years ago

This silences compiler warnings about this deliberate decision, so in future it will be easier to spot compiler warnings about mistakes; also, it should now be possible to compile with -Wall -Wextra -Werror.

DavidGriffith commented 6 years ago

I added some workarounds for compilers that lack the fallthrough attribute.

DavidGriffith commented 6 years ago

I accidentally pushed the merge before fully testing it. The workaround didn't work. @escondida, would you please redo this with the correct workarounds to allow for compilers that do not have the fallthrough attribute, making sure that it works for CLANG and GCC version 7 and above?

escondida commented 6 years ago

Sure, I'll see what I can do.

DavidGriffith commented 6 years ago

It needs to be transparent for compilers that lack the fallthrough attribute.