DavidGriffith / frotz

Infocom-style interactive fiction player for Unix and DOS (moved to https://gitlab.com/DavidGriffith/frotz)
GNU General Public License v2.0
209 stars 64 forks source link

src/common/quetzal.c: Do not implicitly fall through in case statement #69

Closed escondida closed 6 years ago

escondida commented 6 years ago

Sorry for the delay in getting back to you on this.

Rather than using the fallthrough attribute to mark the deliberate falls through as such, I've instead opted to skip the chunk in each spot (which is what would happen when it falls through). This way, compilers old and new can live in peace and harmony.

I should note that I wasn't sure how to actually test this functionality; I can say that saves definitely load successfully, but I don't have any with chunks to be skipped to test. Also, I don't have any old compilers lying around, so you might want to double-check my "peace and harmony" claim.

Share and enjoy!