search

DavidKarlas / OsmNightWatch

https://nightwatch.openstreetmap.si/
MIT License
14 stars 4 forks source link

Catch broken coastlines with semicolon separated values #15

Open b1tw153 opened 11 months ago

b1tw153 commented 11 months ago

Include ways with semicolon separated values of natural=* where one of the values is "coastline" in the list of broken coastlines. The natural=coastline;bare_rock tag is the most common example of this.

Just a suggestion for an added feature, since these ways are also broken coastlines.

DavidKarlas commented 11 months ago

Problem is that most if not all software working with coastlines only handles exactly natural=coastline and not looking for mult-value tag separated with ;, https://github.com/osmcode/osmcoastline is such example as far as I understand... If osmcoastline software and few others would start handing ; or at least to be shown as landmass on osm.org I would be fine with this change logic in NighWatch... See https://overpass-turbo.eu/s/1DfE for example they are not rendered as islands on OSM today...

b1tw153 commented 11 months ago

Thanks for looking at the issue. I'm not sure from your answer -- did you decide to flag values like natural=coastline;bare_rock as broken coastlines?

DavidKarlas commented 10 months ago

Oh no, I totally misunderstood your ask, I thought you wanted me to process anything with coastline;* as valid coastline, but instead you are asking me to flag those as problems?

b1tw153 commented 10 months ago

Yes, that's right -- flag natural=coastline;* as problems, for all the reasons you mentioned.

Sorry if my original post wasn't clear!

DavidKarlas commented 10 months ago

How would I fix natural=coastline;bare_rock? Duplicate existing way and put tags on existing way natural=coastline and on duplicated geometry I would put natural=bare_rock?

b1tw153 commented 10 months ago

Yes, exactly. That's one way of separating the tags.

It’s also possible to use a multipolygon with natural=bare_rock and with the coastline way as a member. That’s what the Wiki suggests (https://wiki.openstreetmap.org/wiki/Tag:natural%3Dcoastline#How_to_enter_the_data) but I believe the preferred approach is to duplicate the geometry.