search

DavidLGoldberg / jumpy

The fastest way to jump around files and across visible panes in Atom
https://atom.io/packages/jumpy
MIT License
123 stars 16 forks source link

atom-text-editor.Object.defineProperty.get is deprecated. #102

Closed zubaird closed 7 years ago

zubaird commented 7 years ago

The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead.

atom-text-editor.Object.defineProperty.get (/Users/zubair/Downloads/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:68:18)
<unknown> (/Users/zubair/.atom/packages/jumpy/lib/jumpy-view.coffee:417:30)
Workspace.observeTextEditors (/Users/zubair/Downloads/Atom.app/Contents/Resources/app.asar/src/workspace.js:329:9)
JumpyView.jump (/Users/zubair/.atom/packages/jumpy/lib/jumpy-view.coffee:400:50)
JumpyView.getKey (/Users/zubair/.atom/packages/jumpy/lib/jumpy-view.coffee:192:14)
atom-workspace.commands.(anonymous function) (/Users/zubair/.atom/packages/jumpy/lib/jumpy-view.coffee:101:28)
DavidLGoldberg commented 7 years ago

99% sure this is not an issue anymore. It's either been removed or fixed in Atom. Atom doesn't use shadow anymore I can't find references of my using it anymore either.