search

DavidLGoldberg / jumpy

The fastest way to jump around files and across visible panes in Atom
https://atom.io/packages/jumpy
MIT License
123 stars 16 forks source link

Add cyrillic #103

Closed denysdovhan closed 2 years ago

denysdovhan commented 7 years ago

With cyrillic characters Jumpy looks like this:

image

Not cool, isn't it?

This fixes that:

image

Warning: I'm not a good one in RegExp, so probably there is a better solution. Please, check.

DavidLGoldberg commented 7 years ago

Sorry, for waiting so long to get back to you, I saw this but was busy at the time, and forgot :(

I want to merge this but the lowercase I'm guessing а-я ....should be where the other lower case characters are in that regex.......there are 2 sets of them to handle cases like myCoolVar

Can you fix this and I'll merge it. It's funny the other day I was using simplified chinese characters at work and they didn't work for Jumpy either, I'll have to get around to adding those too.

DavidLGoldberg commented 7 years ago

so I think it should maybe be:

Just curious are the A's the same character btw?

default: '([A-ZА-Я]+([0-9a-zа-я])*)|[a-zа-я0-9]{2,}'
DavidLGoldberg commented 7 years ago

Ah, I see yeah the 'a' is totally a different character makes sense.

DavidLGoldberg commented 7 years ago

@denysdovhan Does the above make sense? For the camel casing? I was waiting for your reply, but I can push that commit on top of yours early next week!

denysdovhan commented 7 years ago

@DavidLGoldberg sorry for late. Fixed that. However, I've noticed the strange behavior with ', ’, etc characters, so we have this:

image

DavidLGoldberg commented 7 years ago

ah, interesting yeah, why doesn't the ci in 'cim' get ci labeled...

DavidLGoldberg commented 7 years ago

I wonder if I goofed the characters in (the 'a') in one of those pastes :P

DavidLGoldberg commented 7 years ago

Sorry for originally letting this sit. I loved it when I saw it, but was busy...github needs a little push pin or remind me in a day like google's inbox :)

I need to do this for the Chinese char set also

DavidLGoldberg commented 7 years ago

Have to run, I'll be back later, I can take a look later also, I'll take the PR as long as we think it makes it better and "does no harm" etc.

denysdovhan commented 7 years ago

github needs a little push pin

just set a reminders for corresponding emails from github :wink:

I can take a look later also

No problem. I'm going to use a custom settings until a better solution.