DavidLGoldberg / jumpy

The fastest way to jump around files and across visible panes in Atom
https://atom.io/packages/jumpy
MIT License
124 stars 16 forks source link

:art: Factor out labels into a module #97

Closed DavidLGoldberg closed 6 years ago

DavidLGoldberg commented 7 years ago

This is a little rough around the edges...

Literally... I had to pass in a few too many things to the drawLabels. A little weird.

Overall though I think it's a step forward. The mobx experiments I've been working on touch unrelated code in jumpy-view.coffee (thank god).

This isn't really particularly ready for a big review yet...

Although all of the same tests pass. Performance is the same.

DavidLGoldberg commented 6 years ago

Went live in a commit, but very refactored since.