search

DavidMStraub / homeassistant-homeconnect

Custom component for Home Assistant to connect appliances supporting the Home Connect standard
MIT License
118 stars 29 forks source link

added light brightness support #100

Closed Sjack-Sch closed 4 years ago

Sjack-Sch commented 4 years ago

Addition to #57. Home Assistant brightness (0-255) will be converted to Home Connect brightness (10-100) and vice versa.

GrumpyMeow commented 4 years ago

Hi David, could you maybe merge this Pull Request?

DavidMStraub commented 4 years ago

Looks great! Just a couple of minor comments above.

DavidMStraub commented 4 years ago

could you maybe merge this Pull Request?

Yeah sorry I somehow missed it.

GrumpyMeow commented 4 years ago

I implemented AmbientLight control: https://github.com/Sjack-Sch/homeassistant-homeconnect/pull/1

Sjack-Sch commented 4 years ago

I implemented AmbientLight control: Sjack-Sch#1

Thanks, shall we wait merging ambient until brightness is merged? In the mean time I can test your version on a hood without ambient support.

DavidMStraub commented 4 years ago

Done?

Sjack-Sch commented 4 years ago

Done?

Yep

anthonyangel commented 4 years ago

I implemented AmbientLight control: Sjack-Sch#1

GrumpyMeow, could you please create a pull request from DavidMStraub/homeassistant-homeconnect to add your AmbientLight control?

I loaded up the code in that PR to test, the ambient light (including on/off, colour & brightness) works as expected for a hood, but not for a dishwasher, I was getting the error: Error while trying to turn on light: {'key': 'SDK.Error.UnsupportedSetting', 'description': 'Setting is not supported'} (I can't think of when I'd use the dishwasher light, but as it was there I figured that I'd give it a try anyway.

There was another issue that the startup time of the home_connect_beta component was about 6 minutes, which is long

DavidMStraub commented 4 years ago

Do you have an idea what it was doing in the 6 minutes?

anthonyangel commented 4 years ago

I have 'Waiting on integrations to complete setup: home_connect_beta' entries in the logs, but not much else. I'm increasing the logging of 'homeassistant.bootstrap' to debug and will try again

Sjack-Sch commented 4 years ago

I implemented AmbientLight control: https://github.com/Sjack-Sch/homeassistant-homeconnect/pull/1

@GrumpyMeow, I added the ambient with #105. Can you please help testing.

Sjack-Sch commented 4 years ago

I implemented AmbientLight control: Sjack-Sch#1

GrumpyMeow, could you please create a pull request from DavidMStraub/homeassistant-homeconnect to add your AmbientLight control?

I loaded up the code in that PR to test, the ambient light (including on/off, colour & brightness) works as expected for a hood, but not for a dishwasher, I was getting the error: Error while trying to turn on light: {'key': 'SDK.Error.UnsupportedSetting', 'description': 'Setting is not supported'} (I can't think of when I'd use the dishwasher light, but as it was there I figured that I'd give it a try anyway.

There was another issue that the startup time of the home_connect_beta component was about 6 minutes, which is long

Hi @anthonyangel, Could you test #105, I added an additonal check: if the device has the Ambient feature before creating the Ambient light entity.

GrumpyMeow commented 4 years ago

I’m on holiday for 2 weeks and this can’t help at this time with these changes. Sorry.