search

DavidMStraub / homeassistant-homeconnect

Custom component for Home Assistant to connect appliances supporting the Home Connect standard
MIT License
118 stars 29 forks source link

Add binary sensors for finished and running state #135

Closed olekenneth closed 2 years ago

olekenneth commented 2 years ago

I had a problem trying to make an automation for when the washer was finished, so to me it made sense to have binary sensors for the state as well.

I also wrote the state switching a bit different then you did, what do you think?

olekenneth commented 2 years ago

I see you don't have any tests here. The branch needs to be checked out and tested, because I merged code that I had running I while back.

DavidMStraub commented 2 years ago

I'm sorry for not reacting to this PR but I got kind of overwhelmed by not being able to keep this repository up to date with upstream changes to the HA core integration. Did you contrbute something there in the meantime or check wheteher some of the features are already implemented there?

olekenneth commented 2 years ago

Yes to both. I contributed to Home Assistant as well: https://github.com/home-assistant/core/pull/61544 And I found out that I can now use the operation state instead.

So thank you for getting back to me. But I guess it's better to close this.