search

DavidMStraub / homeassistant-homeconnect

Custom component for Home Assistant to connect appliances supporting the Home Connect standard
MIT License
117 stars 29 forks source link

Added On/off light control for Hood #98

Closed Sjack-Sch closed 4 years ago

Sjack-Sch commented 4 years ago

possible solution to #57. Also added nl.json.

anthonyangel commented 4 years ago

I'd quite like control of the RGB ambient lights in my hood too, but it makes sense to me to leave this PR as-is, and then extend the functionality this once this has been merged rather than putting more into this one

DavidMStraub commented 4 years ago

There are hoods with RGB ambient lights? Wow :-D

anthonyangel commented 4 years ago

There are hoods with RGB ambient lights? Wow :-D

Yep, I have https://www.bosch-home.co.uk/product-list/DWF97MS70B#/Tabs=section-highlights/

The ambient light has different API endpoints to the functional (cooking) one: https://developer.home-connect.com/docs/api/settings/ambientlight

Sjack-Sch commented 4 years ago

Thanks David, the supported_definition was missing. Shall I add this brightness support to this pull request or do you want to merge the current version first and add brightness support using a next pull request?

DavidMStraub commented 4 years ago

As you prefer, we can also merge it now and gather feedback while you implement brightness.

Sjack-Sch commented 4 years ago

Let's merge it now.