search

DavidMStraub / netviel

Web interface for the notmuch e-mail system
MIT License
54 stars 12 forks source link

Replaced deprecated import for safe_join (now: werkzeug.security) #15

Closed cookie4701 closed 1 year ago

DavidMStraub commented 2 years ago

Thanks for this PR!

Can you please add the link to the documentation in flask that this is deprecated?

Also, can you please check what the minimum version of flask and werkzeug are that are required for these imports to work and make sure we have those minimum versions required in setup.py?

DavidMStraub commented 2 years ago

Ok, saw the ImportError in https://github.com/DavidMStraub/netviel-docker/issues/1 only now. But we have to make sure the right flask version is required.

lmanul commented 2 years ago

Stupid question (sorry): what is the downside of using os.path.join instead? I saw the same import error today for the first time, and just used os.path.join instead.

DavidMStraub commented 2 years ago

From the docs:

Safely join zero or more untrusted path components to a base directory to avoid escaping the base directory.

DavidMStraub commented 1 year ago

Superseded by #17.