DavidMoore / ipfilter

Keeps your preferred Bit Torrent client blocklist up to date to support your privacy and security
https://www.ipfilter.app
MIT License
447 stars 38 forks source link

This IPFilter MSI/Script fails if previously a filter was loaded through Qbittorrent interface #62

Open eltrkbrd opened 5 years ago

eltrkbrd commented 5 years ago

Thanks for this excellent tool / script!

I discovered what appears to be a major bug. I'm running the latest Windows 10 Pro & Qbittorrent v4.1.8

This IPFilter MSI/Script fails if previously a filter was loaded through Qbittorrent interface.

I had previously loaded the biglist.p2p filter list (http://john.bitsurge.net/public/biglist.p2p.gz) through the Qbittorent interface but disabled it first before installing your app.

After running your script and reading the log, I opened "C:\Users\XYZ\AppData\Roaming\qBittorrent\qBittorrent.ini" in my text editor and it showed "IPFilter\Enabled=false" which I thought that was odd. Also the .ini showed the path of my previous filter list for "IPFilter\File="

The solution for me was to open Qbittorrent, go to "Connection" and click the checkbox to re-enable the "filter path" so I could delete the biglist.p2p I had loaded previously from being greyed out in the text box. I then unchecked it to disable filter path.

I then navigated to "C:\Users\XYZ\AppData\Local\IPFilter" and deleted everything (except IPFilter.exe) that your app previously downloaded and compiled (I'm not sure this was necessary but wanted a fresh start).

I then ran your IPFilter app again as normal and this time it did work properly: "C:\Users\XYZ\AppData\Roaming\qBittorrent\qBittorrent.ini" now correctly shows under [Preferences]: IPFilter\File=C:/Users/XYZ/AppData/Local/qBittorrent/filter/ipfilter.dat IPFilter\Enabled=true

When opening Qbittorrent | Connection options, the "IP Filtering" | "Filter Path" is unchecked and the previous script doesn't show grayed out like before.

Perhaps this will help someone else out. The log showing everything went ok but in fact it can be misleading.

Perhaps instead of an MSI installer you can include a portable .exe version of the IPFilter app (zip download) or even better perhaps a PowerShell script?

Thanks again!