added --re-interval to awk in line 65. some GNU awk versions appear …

DavidPageGroup / cdm-data

Tools and information for working with data in CDM format

MIT License

1 stars 1 forks source link

added --re-interval to awk in line 65. some GNU awk versions appear … #3

Closed jbadger3 closed 5 years ago

jbadger3 commented 5 years ago

@afbarnard I added --re-interval to the data cleaning step of awk. When I tried cleaning the most recent version of the OMOP files the dates remained unchanged. After doing a little digging it looks like some GNU versions of awk don't allow {} syntax in their regex. Adding --re-interval seems to fix the problem. Cheers, Jon

afbarnard commented 5 years ago

Thanks for the fixes. They all look good.

I've been meaning to add sorting by dates for some time, so your additional changes are a good direction. I would prefer to actually sort by date rather than *_occurrence_id, though, because there aren't any official ordering semantics attached to the occurrence IDs. See my comments on the code.