search

DavidRog / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open aubreywullschleger opened 7 years ago

aubreywullschleger commented 7 years ago

Grade: Meets expectations

Summary: Nice job with this project! I like your use consistent nesting and indentation and your use of the <strong> element.

A couple things to work on here: 1. using locally stored images with descriptive alt attributes for your <img> elements and 2. making your CSS more concise by adding group selectors for repeated styles.

Next, I challenge you to research and implement media queries to make your page totally responsive for all screen widths. This is a challenge I think you are ready for based on your great work here! Here are a couple resources to get you started: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries and https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

DavidRog commented 7 years ago

Thanks so much for the feedback, Aubrey. A few questions:

  1. I've not learned how to use alt attributes. Where can I find information about this? How would this improve my projects?

  2. Can you please explain the concept of making my page responsive for all screen widths? Or will the articles you've enclosed explain all of this? Thanks so much again, I appreciate any opportunity to better my coding skills!