search

DavidRother / cooking_zoo

CookingZoo: a gym-cooking derivative to simulate a complex cooking environment
MIT License
20 stars 9 forks source link

Feature request: update PettingZoo version #23

Closed elliottower closed 1 year ago

elliottower commented 1 year ago

Hi, would it be possible to update this repo to use the most recent version of PettingZoo? This project is listed in PettingZoo's third-party-environments, but we only want to include environments which work with the current version.

If you need any help working out issues due to different versions feel free to ask, there were some breaking changes in version 1.2, so it requires a bit of code changes to adapt. The previous API returned done in the step() function, whereas the new one returns truncated and terminated (matching gymnasium). There is a migration guide for gymnasium explaining the changes further, the steps should be basically the same (we're working on making resources for updating old PettingZoo repositories as well): https://gymnasium.farama.org/content/migration-guide/

DavidRother commented 1 year ago

Hi, the environment is now updated on the main branch with new instructions, testscripts and full support of the pettingzoo library in its latest version. I will look to update from gym to gymnasium as a next step. If there are problems beyond that please let me know.

elliottower commented 1 year ago

Thanks so much! If you’d like to open a PR updating your environment in our third party environments list (to use your own wording for the title/headline, etc) feel free, otherwise let me know and I can do it.

DavidRother commented 1 year ago

It would be great if you could write the PR. thank you!