search

DavidRouyer / pipedrive-dotnet

Pipedrive.net is an async .NET Standard client for pipedrive.com
MIT License
38 stars 46 forks source link

Api Deal Products Breaking Changes #107

Closed Sprudhomme closed 2 years ago

Sprudhomme commented 2 years ago

Describe the bug Pipedrive api changed to update PUT prices to be sent as an array of objects instead of an object : https://developers.pipedrive.com/changelog/post/breaking-change-in-products-endpoint-and-webhook

Also breaking GetProducts from deal since it was using the same model

Created a PR with a fix I am running from my updated dll at the moment.

To Reproduce Steps to reproduce the behavior:

  1. Fetch deal products

Expected behavior Return products of Deal

Screenshots Cannot deserialize the current JSON array (e.g. [1,2,3]) into type 'System.Collections.Generic.Dictionary`2[System.String,Pipedrive.ProductPrice]' because the type requires a JSON object (e.g. {"name":"value"}) to deserialize correctly Path 'data[0].product.prices', line 1, position 939.

DavidRouyer commented 2 years ago

Fixed in fada60ebbee79ae93aa16403dcf2eec7e468fd9d

DavidRouyer commented 2 years ago

Tell me if it's good in 0.5.18

Sprudhomme commented 2 years ago

Yes! Working as intended in 0.5.18