search

DavidSouther / grunt-docco

Docco task for Grunt.
MIT License
70 stars 37 forks source link

Update to work with docco 0.6.x #19

Closed gregberge closed 11 years ago

gregberge commented 11 years ago

I have updated your plugin in order to work with docco 0.6.x. I have updated Gruntfile.js too, because there was linting error and an unknown lint task. Tests are OK.

neocotic commented 11 years ago

I submitted a PR over 2 months ago that adds this functionality. Did you not look at the open issues before doing this?

My PR cannot be merged in until the next version of docco is released as it will include my changes to support programmatic execution.

Regardless, you approach would not work in a Gruntfile that has more than one docco task as docco 0.6.x currently only supports a single execution as the internal configurations are not cleared for subsequent calls. This is because it only expects to be called from the command line. 0.6.3 will include my changes which correctly maintains state per API call.

Please see #14 for more information.

gregberge commented 11 years ago

Ok, no i didn't look at the open issues before. It's cool if you are working on it.

An other thing, in my commit, i move grunt into peerDependencies, may be you have already planed to do this.

Thanks.

neocotic commented 11 years ago

I've already added grunt to peerDependencies. Please see https://github.com/neocotic/grunt-docco/commit/c114ff302332c44cf356c712603750c816aed027#L1R42.

gregberge commented 11 years ago

Ok cool!