search

DavidSouther / grunt-docco

Docco task for Grunt.
MIT License
70 stars 37 forks source link

Fix for highlight.js #35

Closed neocotic closed 10 years ago

neocotic commented 10 years ago

Recently the highlight.js library that is used by docco was updated with breaking changes. Although these changes were done in a major release, docco had the dependency marked in such a way that all versions after 7.0.0 were allowed.

This issue has been fixed on the latest commit on the docco master branch, which I've updated our dependency to reference until the next official release of docco (or another breaking bug is discovered and fixed).

Please can you merge this in and bump the version of this plugin on npm.

neocotic commented 10 years ago

This PR will fix #34.

DavidSouther commented 10 years ago

docco#master also works for our multi-task issues?

neocotic commented 10 years ago

Well, technically we're not using master, but close enough. It did for me and my tests anyway. However, I don't know if anyone tested the specific grunt-watch issue used in that bug.

Without this new PR, new installations of this plugin will have errors when run.

DavidSouther commented 10 years ago

Ugh. Ok. #thanksdocco

neocotic commented 10 years ago

Yea, it's all frustrating considering that I see no reason why programmatic usage of docco was working fine before it was all stripped in the v0.6 release and now it's being slowly put back together again.

When you get a minute could you please update npm as I can tell that's going to be the next request from devs.

DavidSouther commented 10 years ago

0.3.2 pointing at docco#d6a7f7dc94 is published, should show up in the registry as soon as it updates.

@neocotic is listed as a maintainer on npm, so you should be able to push updates as well. I added grunt-release, so it's as easy as grunt release

neocotic commented 10 years ago

Ah, brilliant. I wasn't sure if I could publish there too. I'll start merging PR's and publishing releases as required too then to spread the load.

neocotic commented 10 years ago

@DavidSouther For some reason your publish didn't work. However, I merged the latest changes into my fork and did the publish from there. 0.3.2 is now live on npm.