search

DavidT3 / XGA

X-ray: Generate and Analyse is a module designed to make the analysis of XMM observations simple and efficient. It provides an interface with SAS for the creation of XMM data products, as well as a way to easily perform fits (scalable for multiple observations) and retrieve information about an object, all within a Python package.
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

emosiac + NullSource should be able to make single ObsID merged images #821

Open DavidT3 opened 2 years ago

DavidT3 commented 2 years ago

I think this modification should be relatively simple, but occasionally I find it useful to just look at stacked images from a single observation (when looking for flaring for instance) and there isn't actually a simple way of doing that in XGA at the moment. Modifying NullSource and emosaic so that this feature works.

DavidT3 commented 2 years ago

Should I alter NullSource so that it actually can store Images? The Image product class has come a long way from where it was when I originally wrote NullSource - now data is only loaded from disk into memory when its actually needed, rather than on definition. Excessive memory use was one of my main concerns with NullSource originally.

However, this might be better served by a complete rewrite of the class, or a new class altogether, that can automatically combined intersecting images without looking for a specific source. Adding those collections of images together would be good for source finding with all available data. This would deserve an entirely different issue I think

DavidT3 commented 2 years ago

I opened a branch to perform this work in, and then the need got less urgent so I haven't actually made any progress on it. I'm housekeeping the repo at the moment, and I'm going to delete the branch and leave the issue open.