search

DavidT3 / XGA

X-ray: Generate and Analyse is a module designed to make the analysis of XMM observations simple and efficient. It provides an interface with SAS for the creation of XMM data products, as well as a way to easily perform fits (scalable for multiple observations) and retrieve information about an object, all within a Python package.
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

WCS object not defined when loading region files in sky coordinates #907

Open DavidT3 opened 1 year ago

DavidT3 commented 1 year ago

Vardan discovered a bug whilst attempting to use XGA - the region files he has access to are in RA-Dec coordinates, which in theory make it easier because they don't have to be converted from a specific image's pixel coordinates. Unfortunately the 'regions' module requires a WCS to run the 'contains' check on the source coordinate (I don't think it should need it but ah well). As such I will probably implement my own method to run if the WCS is unavailable, based on the 'regions within radii' method that I created.

First things first though, I'll make sure a WCS is defined in Vardan's use case (where images are available).

DavidT3 commented 1 year ago

I might leave this open as a reminder, even if the specific issue is fixed.