search

DavidTanner / nodecredstash

MIT License
43 stars 22 forks source link

You should install aws-sdk as a peerDependency #13

Closed grvcoelho closed 7 years ago

grvcoelho commented 7 years ago

You should define aws-sdk as a peerDependency, to avoid conflicts with projects already using aws-sdk.

DavidTanner commented 7 years ago

There shouldn't be any conflicts. nodecredstash doesn't attach anything to the existing aws-sdk library, and is not meant to work as a plugin, which is what peerDependencies are for.