search

DavidVentura / Wireguard_qml

UBPorts app in QML for Wireguard
MIT License
4 stars 5 forks source link

python: vpn.can_use_kernel_module() detection is buggy #4

Closed fredldotme closed 2 years ago

fredldotme commented 3 years ago

After importing WireGuard into the Pixel 3a port I tried the WireGuard QML application, but the detection of kernel support is buggy.

src/vpn.py/can_use_kernel_module() detects the kernel support via a sudo command, though the users password is never requested, resulting in failure of the detection altogether.

Manually running its commands on the Pixel 3a allows the WireGuard link device to be created and deleted successfully, so I assume the app needs to request the users password similarly to what ISODrive does: https://github.com/fredldotme/ISODriveUT/blob/master/src/commandrunner.cpp

luksus42 commented 3 years ago

It is the same issue on Fairphone 3.

DavidVentura commented 2 years ago

interesting; i don't have a sudo password and never set one, assumed it was the same for everyone on UT. there is plenty of sudo usage, i'll take a look at how other apps do this, but i think it will be somewhat challenging, as things like the daemon need sudo to update the routes on network change, etc

Joshndroid commented 2 years ago

@fredldotme Did you get this working?