DavidVollmers / Ignis

The Blazor framework for building modern web applications.
https://ignis.dvolper.dev
MIT License
137 stars 8 forks source link

Fix transition/dialog/outlet bug & e2e tests #27

Closed DavidVollmers closed 9 months ago

DavidVollmers commented 9 months ago

This PR introduces e2e tests running against https://e2e.ignis.dvolper.dev to test full functionality of opening/closing a Dialog within a Transition rendered from a DialogOutlet.

This PR also fixes a bug with the above described issue.

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% :tada:

Comparison is base (28eb66d) 38.21% compared to head (40e0d95) 38.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #27 +/- ## ========================================== + Coverage 38.21% 38.35% +0.14% ========================================== Files 75 75 Lines 2570 2576 +6 ========================================== + Hits 982 988 +6 Misses 1588 1588 ``` | [Files Changed](https://app.codecov.io/gh/DavidVollmers/Ignis/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dvolper) | Coverage Δ | | |---|---|---| | [packages/Ignis.Components/ContentRegistry.cs](https://app.codecov.io/gh/DavidVollmers/Ignis/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dvolper#diff-cGFja2FnZXMvSWduaXMuQ29tcG9uZW50cy9Db250ZW50UmVnaXN0cnkuY3M=) | `100.00% <100.00%> (ø)` | | | [packages/Ignis.Components/IgnisComponentBase.cs](https://app.codecov.io/gh/DavidVollmers/Ignis/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dvolper#diff-cGFja2FnZXMvSWduaXMuQ29tcG9uZW50cy9JZ25pc0NvbXBvbmVudEJhc2UuY3M=) | `88.37% <100.00%> (+0.27%)` | :arrow_up: | | [...is.Components/IgnisContentProviderComponentBase.cs](https://app.codecov.io/gh/DavidVollmers/Ignis/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dvolper#diff-cGFja2FnZXMvSWduaXMuQ29tcG9uZW50cy9JZ25pc0NvbnRlbnRQcm92aWRlckNvbXBvbmVudEJhc2UuY3M=) | `93.10% <100.00%> (ø)` | | | [...Tailwind/Ignis.Components.HeadlessUI/Transition.cs](https://app.codecov.io/gh/DavidVollmers/Ignis/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dvolper#diff-cGFja2FnZXMvVGFpbHdpbmQvSWduaXMuQ29tcG9uZW50cy5IZWFkbGVzc1VJL1RyYW5zaXRpb24uY3M=) | `91.12% <100.00%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.